Retire the discovery-extension files an --oldcopy upgrade leaves behind - #1531

Follow-up to #1528, found while deploying it to a live server.

configureHttpd()'s retirement sweep matched *.class.php only. #1528 retired
52 more files the same way — every core page, hook, report and event moved from
lib/{pages,hooks,reports,events}/<lowercase>.<type>.php to
src/<Bucket>/<Class>.php — so on FOG_copy_back_old=yes all 52 survive the
upgrade.

Why this is not the harmless case the existing comment describes

A stale *.class.php is inert: autoload() answers a bare name out of src/
before it consults the scanned class map, so those files are clutter on the
include path and nothing more. That is what the comment in place today says,
and it is true.

A stale *.report.php is found. ReportManagement::loadCustomReports()
merges core's src/Reports with the fileitems() walk that picks up plugin
reports, and that walk reaches lib/reports/ too. Every core report is
discovered twice, and the Reports menu renders each of them twice.

Reproduced, not argued

Restoring the 52 pre-#1528 files into a deployed 1.6 webroot and re-running the
discovery probe:

-REPORTS(17): audit report|file deleter|fleet report|hardware report|…
+REPORTS(30): audit report|audit report|file deleter|file deleter|fleet report|fleet report|…

Worth noting what did not catch it: a full page-and-report HTTP sweep of the
same server — 30 page nodes and all 17 reports, asserting status, body size and
absence of a PHP error — stayed at 52 passed, 0 failed with the stale files in
place. The duplicate is in the menu, and every duplicate link works. Only the
probe that reports what discovery actually found could see it.

The fix

The find asks for the four discovery extensions alongside the class files.
The keep-if-still-shipped test is unchanged, and is what makes the wider match
safe: lib/router/ still ships its .class.php files and they are matched,
tested and kept exactly as before. -maxdepth 2 still holds the bundled-plugin
boundary at lib/plugins/<name>/<dir>/.

Gates

tests/oldcopy-retires-moved-classes.test.sh gains three checks — a retired
file of each of the four kinds is removed, a discovery-extension file the
release still ships is spared, and a bundled plugin's report one level deeper is
left to the fog-plugins release.

Both mutations fail it, run rather than assumed:

Its extractor also had to change. It lifted the loop out of functions.sh and
stopped at the first done < <(find line; the find is a multi-line -o list
now, so that terminator would cut the snippet mid-command. It stops on -print0
instead.

Suite: 239 passed, 0 failed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VTEiBnDpNrgzu1tSqt1318